feat!: wire ibcfee module #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
p-offtermatt
reviewed
Apr 3, 2024
mpoke
reviewed
Apr 10, 2024
| @@ -114,6 +117,7 @@ type AppKeepers struct { | |||
|
|
|||
| // Modules | |||
| ICAModule ica.AppModule | |||
| IBCFeeKeeper ibcfeekeeper.Keeper | |||
There was a problem hiding this comment.
Don't we need also a scoped keeper for this?
There was a problem hiding this comment.
Not as far as the docs are concerned. I don't see the scoped FeeKeeper
mpoke
approved these changes
Apr 10, 2024
Co-authored-by: bernd-m <[email protected]>
insumity
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2948
This PR adds support for IBC fee middleware.
The middleware is connected to the transfer and ICA modules.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change